geopython / pywps

PyWPS is an implementation of the Web Processing Service standard from the Open Geospatial Consortium. PyWPS is written in Python.

https://pywps.org

MIT License

178 stars 117 forks source link

fix output mimetype assuming string #626

Closed cehbrecht closed 3 years ago

cehbrecht commented 3 years ago

Overview

This PR merges PR #623 from pywps-4.4 branch.

Related Issue / Discussion

623 #620

Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[ ] I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
[x ] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

coveralls commented 3 years ago

Coverage remained the same at 0.0% when pulling fd6102241a848a8e740508dc611d0aa4dabad360 on merge-pr-623-mimetype-none into 6e609c25a64784ee8b332eb53c24eb937995df17 on main.

cehbrecht commented 3 years ago

@fmigneault Could we make it shorter?

mimetype = mimetype or ''

fmigneault commented 3 years ago

@cehbrecht

@fmigneault Could we make it shorter?
mimetype = mimetype or ''

Yes, should be equivalent in this case.

You will need to re-merge back into https://github.com/geopython/pywps/blob/pywps-4.4 this change though to avoid diverging.