geopython / pywps

PyWPS is an implementation of the Web Processing Service standard from the Open Geospatial Consortium. PyWPS is written in Python.

https://pywps.org

MIT License

178 stars 117 forks source link

Create output directory before estimating available space on device #636

Closed huard closed 2 years ago

huard commented 3 years ago

Overview

For file storage, the available space on device is computed before directory is created. This fails when the output path requires creating multi-level directories.

Related Issue / Discussion

Fix #635

Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[x] I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
[x] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

huard commented 3 years ago

@cehbrecht Any idea about the GDAL error. Shouldn't it be updated to version 3 ?

tlvu commented 3 years ago

@huard Does this create dir fix for server.outputpath also apply for server.workdir and server.temp_path in wps.cfg? If not then we should also ensure these dir are created in not exist, see https://github.com/geopython/pywps/issues/635#issuecomment-956551246.

Otherwise, PR LGTM, thanks !

huard commented 3 years ago

I don't think so. I haven't added a test yet to the PR. I could try to check that at the same time.

coveralls commented 3 years ago

Coverage remained the same at 0.0% when pulling afdb9a69197aa9ac3a48724cf5880fa77c19bd72 on huard:fix-635 into 626e2cfffb7169c6ef833e8e8af813c4035ae5be on geopython:main.

huard commented 3 years ago

I added a test confirming that nested directory creation for stored objects work. Thanks @cehbrecht for the GDAL fix.

cehbrecht commented 2 years ago

@huard looks good :) Feel free to merge.