geopython / pywps

PyWPS is an implementation of the Web Processing Service standard from the Open Geospatial Consortium. PyWPS is written in Python.
https://pywps.org
MIT License
175 stars 117 forks source link

Fix invalide use of encode on bytes object #651

Closed gschwind closed 2 years ago

gschwind commented 2 years ago

Within the pywps.inout.inputs.ComplexInput the json convertion function use encode where decode should be used. The patch fix this issue.

same as #647 but main branch as base

Overview

Related Issue / Discussion

Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.03%) to 81.253% when pulling 42b7508155efc6234781cf937e029d1f5b562148 on gschwind:main-fix-request-storage into c8d1fe1b7781a9ad6f85c74ad4b5afad520ac380 on geopython:main.

cehbrecht commented 2 years ago

@gschwind Tests are all passing. Would you like to add a test to prove it is doing the right thing?

cehbrecht commented 2 years ago

@gschwind Tests are all passing. Would you like to add a test to prove it is doing the right thing?

gschwind commented 2 years ago

I will have a look to add test, best regards

gschwind commented 2 years ago

I did a test but I'm not satisfied because the serialization-deserialition is not symmetric :)

and the test is not symmetric too.

gschwind commented 2 years ago

I updated the test to only test the decoding, it should be fine now