geopython / pywps

PyWPS is an implementation of the Web Processing Service standard from the Open Geospatial Consortium. PyWPS is written in Python.
https://pywps.org
MIT License
175 stars 117 forks source link

Improve the implementation of pywps.inout.literaltypes #668

Closed gschwind closed 1 year ago

gschwind commented 1 year ago

Overview

I used function decoration to improve the pywps.inout.literaltypes. This make the code quite nicer to read and avoid mistake when mapping types and their corresponding converter.

Related Issue / Discussion

Additional Information

This contribution is supported by MINES ParisTech.

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

coveralls commented 1 year ago

Coverage Status

Coverage: 81.381% (-0.02%) from 81.398% when pulling d4ee66230c021f3849bff918d9f3c2173c146d31 on gschwind:improve-literaltype-implementation into 6fa8a212387ea69af7e1d51c15ed2243c012e7a6 on geopython:main.

gschwind commented 1 year ago

Hello,

I do not understand the issue with the doc, do someone can help ?

Best regards

cehbrecht commented 1 year ago

@gschwind looks like tests are failing due to pep8 issues.

huard commented 1 year ago

Run flake8 pywps/inout/literaltypes.py. There is some extra spaces on line 30.

cehbrecht commented 1 year ago

@gschwind thanks :) Improvements (@huard) could be added with another PR.