Closed fmigneault closed 12 months ago
@fmigneault with PR #687 the tests should work again. If you think this PR is ready I can merge it.
@cehbrecht Can you consider this fix into 4.6.0 release?
On my side, the tests were running, but you can combine them with the other PR to validate they work together. Thanks!
Overview
Fix process description literal UOMs reporting duplicates of the first default UOM instead of all supported UOMs.
For example, passing
uoms=['metre', 'feet']
toLiteralInput
would cause it to report as follows in the WPS description. The default UOM would be repeated for as many supported UOMs that were passed to the input.At the same time, this fixes the optional
reference
attribute accordingly if it was not provided explicitly, or could not be mapped to a known unit of OGC URN.According to https://schemas.opengis.net/ows/1.1.0/owsDomainType.xsd the
ows:UOM
which depends onows:DomainMetadataType
shows<attribute ref="ows:reference" use="optional" />
But the previous check of
UOM
class caused it to check ofOGCUNIT
if not provided with an empty string. The correspondingif
in the template were also not consistent about reportingreference
.Related Issue / Discussion
Required by https://github.com/crim-ca/weaver/pull/541 Required by https://github.com/crim-ca/weaver/issues/430 Fixes https://github.com/geopython/pywps/issues/685
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)