search

georchestra / data-api

OGC API Features implementation for geOrchestra
GNU General Public License v3.0
1 stars 2 forks source link

ogc-features service - sample-data profile to be kept ? #26

Open pmauduit opened 4 months ago

pmauduit commented 4 months ago

We still have a sample-data profile defined in the main (e.g. not "test") codebase: https://github.com/georchestra/data-api/blob/main/src/services/ogc-features/src/main/java/com/camptocamp/opendata/ogc/features/autoconfigure/geotools/SampleDataBackendAutoConfiguration.java

I wonder if this is still useful or if we could consider that the data-api should only work against a postgresql/postgis backend ? For now, the profile is still being used in the https://github.com/georchestra/data-api/blob/main/src/services/ogc-features/src/test/java/com/camptocamp/opendata/ogc/features/server/impl/DataApiImplTest.java class, but maybe we could share the code between this one and the CollectionsApiImplPostgisTest class, so that both share the same postgis backend instead ?

pmauduit commented 4 months ago

It looks like the sample-data profile is still referenced in the README.md: https://github.com/georchestra/data-api/blob/main/src/services/ogc-features/README.md#development

So maybe the profile should be kept, but we could still refactor the testsuite so that it makes use of a postgis container instead of using the sample data provided ?