georchestra / datadir

geOrchestra configuration directory for generic wars & Debian packages (eg: /etc/georchestra)
5 stars 33 forks source link

ogc_api_records should have env var for credentials stores to db #319

Open jeanmi151 opened 11 months ago

jeanmi151 commented 11 months ago

here : https://github.com/georchestra/datadir/blob/docker-master/geonetwork/microservices/ogc-api-records/config.yml#L23

fvanderbiest commented 11 months ago

Good catch ! Let's fix this (and backport on 23.x)

edevosc2c commented 9 months ago

Just stumbled upon this issue too now with isère.

Do we agree to have the envs inside the config.yml instead of overriding it using an environment variable like on k8s: https://github.com/georchestra/helm-georchestra/blob/main/templates/geonetwork/ogc-api-records/ogc-api-records-deployment.yaml#L63C11-L64C111?

Will also need to use envs-database-georchestra file for the service "ogc-api-records"

fvanderbiest commented 9 months ago

Sounds like a fair option