search

georchestra / datadir

geOrchestra configuration directory for generic wars & Debian packages (eg: /etc/georchestra)
7 stars 33 forks source link

console fails with java.lang.NumberFormatException: For input string: "${rabbitmqPort}" #336

Closed jeanpommier closed 1 year ago

jeanpommier commented 1 year ago

With the recent introduction of rabbit MQ, some new config parameters have been introduced in the default.properties file.

Since Rabbit MQ for now only addresses the usage of Gateway, I would say that we should consider it optional, since Gateway is still not the mainstream option. Considering that, it would be good if those config parameters didn't break the apps.

Right now, using the helm chart and docker-master datadir, the console fails with java.lang.NumberFormatException: For input string: "${rabbitmqPort}".

Apparently, the issue is not rabbit MQ not being available, but simply a string to Int conversion error (when RABBITMQ_PORT is not configured). I propose we provide a default value to this env var, to prevent this error. I didn't check it on properties file, but ${RABBITMQ_PORT:-5672} works in the shell and should also work here, I'd say. And at least prevent this error.

jeanpommier commented 1 year ago

Ping rabbitmq guys (@edevosc2c @jeanmi151 ). Any progress on this ?

AFAIK, currently, standard helm chart deployment is broken because of this, and simple docker-compose is broken because of traefik SSL certificate issue. Which means that people wanted to test georchestra using a containerized solution will conclude this is not working and move to something else.

fvanderbiest commented 1 year ago

simple docker-compose is broken because of traefik SSL certificate issue

Tested working yesterday

jeanpommier commented 1 year ago

OK, but in the long run ?

edevosc2c commented 1 year ago

@jeanpommier please submit the quick solution that you proposed: ${RABBITMQ_PORT:-5672}

And we will revise the issue later, thank you :). Don't close this github issue.

jeanpommier commented 1 year ago

I'd say "you broke it you fix it", but well, I'll take some time to submit it

edevosc2c commented 1 year ago

console and gateway just got rabbitmq disabled by default: https://github.com/georchestra/georchestra/pull/4047 https://github.com/georchestra/georchestra-gateway/pull/62

so it shouldn't look for RABBITMQ_PORT and so on anymore.

@jeanpommier can you still reproduce the issue on georchestra master?

jeanpommier commented 1 year ago

Thanks @edevosc2c. I'm still having trouble with the traefik.me certifictae, but the rabbbitmq errors in console logs are not there anymore, so I'd say this is fixed. Thanks !