search

georchestra / datadir

geOrchestra configuration directory for generic wars & Debian packages (eg: /etc/georchestra)
5 stars 33 forks source link

datafeeder - defaultResourceType #338

Closed fvanderbiest closed 9 months ago

fvanderbiest commented 10 months ago

The datafeeder-generated metadata should have

<gmd:hierarchyLevel>
<gmd:MD_ScopeCode codeList="http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#MD_ScopeCode" codeListValue="dataset"/>
</gmd:hierarchyLevel>

... rather than

<gmd:hierarchyLevel>
<gmd:MD_ScopeCode codeList="http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#MD_ScopeCode" codeListValue="series"/>
</gmd:hierarchyLevel>

Since https://github.com/georchestra/datadir/pull/233/files this is dynamically controlled by the datafeeder.publishing.geonetwork.defaultResourceType property.

All branches master, docker-master, 23.0 and docker-23.0 have the following setting in datafeeder.properties:

# defaults to series
#datafeeder.publishing.geonetwork.defaultResourceType=dataset

... which is contradictory.

The default value should be "dataset" rather than "series".

jeanmi151 commented 9 months ago

If i understand correctly it is just a matter of the comment here that need to be changed ? https://github.com/georchestra/datadir/blob/docker-master/datafeeder/datafeeder.properties#L76

fvanderbiest commented 9 months ago

hopefully yes

jahow commented 9 months ago

Also here probably: https://github.com/georchestra/georchestra/blob/41a24e9f93dbd2d69542cf8ccf35043a7af4c8df/datafeeder/src/main/java/org/georchestra/datafeeder/config/DataFeederConfigurationProperties.java#L92

jeanmi151 commented 9 months ago

@jahow PR created https://github.com/georchestra/georchestra/pull/4051