georchestra / docker

Quick start geOrchestra with docker
18 stars 21 forks source link

Added port so that the service-name of static is independent #283

Open hpwjnijs opened 3 months ago

hpwjnijs commented 3 months ago

So traefik sees the 'static' service as static-\<directory>@docker and that how it is addressed. But you want to have it directory independent. There is no direct way to name/label your service , but according to this you can fix this by e.g.

labels:

So, that's what we do here. It fixes #214

(N.B Split up from https://github.com/georchestra/docker/pull/278)

edevosc2c commented 2 months ago

Hello Nijs, thank you for the PR.

The issue lies way deeper than that. For every case where you see "@docker", it's actually the name of the directory.

Which means that even if we make traefik to detect the services, but we would still miss the middlewares like "traefik.http.middlewares.traefik-strip", "traefik.http.middlewares.corsheader" and more.

The real solution is to stop using docker labels for making traefik to discover the services. If we still want to use traefik then we should use traefik static config.

Or there is a pending PR for switching to caddy which aims to solve the issue #214: https://github.com/georchestra/docker/pull/268

hpwjnijs commented 2 months ago

Hello Nijs, thank you for the PR.

The issue lies way deeper than that. For every case where you see "@docker", it's actually the name of the directory.

Which means that even if we make traefik to detect the services, but we would still miss the middlewares like "traefik.http.middlewares.traefik-strip", "traefik.http.middlewares.corsheader" and more.

The real solution is to stop using docker labels for making traefik to discover the services. If we still want to use traefik then we should use traefik static config.

Or there is a pending PR for switching to caddy which aims to solve the issue #214: #268

AFAIK is "@docker" not the directory; We have never experienced any issues (with our other projects) when starting in a different named directory.