search

georchestra / docker

Quick start geOrchestra with docker
18 stars 21 forks source link

Remove georchestra analytics #295

Open edevosc2c opened 1 month ago

edevosc2c commented 1 month ago

Remove georchestra analytics since we can't use it because security proxy was removed.

Also remove security proxy file in envsubst.

This commit may be good to backport in georchestra/docker 24.0

fvanderbiest commented 1 month ago

This commit may be good to backport in georchestra/docker 24.0

Nope. geOrchestra 24 is meant to be usable with both the security-proxy and the gateway.

But I see your point. The docker composition has the gateway by default on branch 24.

Maybe commenting out analytics would be a better option in this branch. In the same idea, having the security-proxy commented out would also make sense in the same branch.

edevosc2c commented 1 month ago

Maybe commenting out analytics would be a better option in this branch.

Fine for me too.

In the same idea, having the security-proxy commented out would also make sense in the same branch.

Well security-proxy is gone from the docker composition: https://github.com/georchestra/docker/blob/24.0/docker-compose.yml and https://github.com/georchestra/docker/pull/197/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3L82-L88

So I thought analytics wouldn't be necessary anymore too.

Maybe we need to bring back SP but commented? And comment analytics.

jeanpommier commented 1 month ago

What about the header. Won't we have a broken entry (analytics) ?