georchestra / georchestra-cas-server

Apache License 2.0
0 stars 3 forks source link

revisit the way messages for password rotation policy are injected #30

Open pmauduit opened 2 months ago

pmauduit commented 2 months ago

Reading the following class: https://github.com/georchestra/georchestra-cas-server/blob/master/src/main/java/org/georchestra/cas/MessagesConfiguration.java I have the feeling that we are trying "to do something against what the framework provides us", and it does not read very "spring-ish":

Also I think that the password rotation policy would deserve some tests or at least a "use-case docker composition" into the dedicated repository.

pmauduit commented 2 months ago

FTR, PR which introduced the change is here: https://github.com/georchestra/georchestra-cas-server/pull/14

pmauduit commented 2 months ago

See above commit for a sample docker composition to try the feature out