search

georchestra / georchestra-gateway

GNU General Public License v3.0
0 stars 6 forks source link

rabbitmq - get rid of the xml configuration files ? #144

Open pmauduit opened 1 month ago

pmauduit commented 1 month ago

It would be a more "spring-boot'-ish approach to use configuration classes, instead of the 2 xml configuration files from the classpath:

pmauduit commented 1 month ago

I am also questioning myself about the added value of the following class: https://github.com/georchestra/georchestra-gateway/blob/main/gateway/src/main/java/org/georchestra/gateway/accounts/events/rabbitmq/RabbitmqEventsListener.java

It is not dead code though, but apart from parsing the message from rabbitMq and logging it, no other action is performed. I guess the intent was first to acknowledge the fact that an action had been performed console-side, but maybe we could just discard the need for a listener here, or maybe keeping it as it is for future usage ?