search

georchestra / georchestra-gateway

GNU General Public License v3.0
0 stars 6 forks source link

automatically build docker image for a pull request #44

Open edevosc2c opened 1 year ago

edevosc2c commented 1 year ago

for development purposes, it would be easier to automatically build a docker image when a pull request is created.

use github actions for that

fvanderbiest commented 1 year ago

Agreed ! Thanks :-)

groldan commented 10 months ago

Do you mean to build the image and also push it to dockerhub for each pull request? I disagree, won't we end up with a ton of images on dockerhub. Is that standard practice? I've seen it on private registries, but not sure about abusing the dockerhub repo that much. Unless we can also remove the image once the PR is merged/closed?

edevosc2c commented 10 months ago

Yes pushing to a docker repository. You can set expiration on dockerhub. That would help in not abusing the platform too much.