search

georchestra / georchestra-gateway

GNU General Public License v3.0
0 stars 6 forks source link

Inform admins when new oauth2 account is created using spring rabbit events (gateway) #54

Closed marwanehcine closed 12 months ago

marwanehcine commented 1 year ago

On this PR, we made use of spring rabbit events to send message from gateway to console in order to inform admin about new created OAuth2 account

marwanehcine commented 1 year ago

EventsConfiguration is an autoconfiguration, please rename as EventsAutoConfiguration for the sake of conventions. Also, it is imperative that it's conditional in some form, and not enabled by default, for backwards compatibility. The gateway shall keep being able to deploy without a rabbitmq at all. You can add for example @Profile("rabbitmq"), then the configuration class will only engage when the app is launched with the spring "rabbitmq" profile.

I made use of property "enableRabbitmqEvents" because I need to check it before calling rabbitMQSender in "OpenIdConnectUserMapper.java". I think this way we can activate to desactivate rabbitmq autoconfiguration. Thanks

fvanderbiest commented 12 months ago

Can someone merge this one if it's OK with you ? Thanks !

marwanehcine commented 12 months ago

Can someone merge this one if it's OK with you ? Thanks !

Please wait I finish with port issues, Thanks