search

georchestra / georchestra-gateway

GNU General Public License v3.0
0 stars 6 forks source link

push to docker hub github actions per commit #74

Closed edevosc2c closed 10 months ago

edevosc2c commented 10 months ago

Allow to retain older versions of the master branch of georchestra gateway.

Each new commit will be available under the docker image georchestra/gateway:commit-the_sha_id

We are currently in a fast moving period of the software, and sometimes it breaks the infrastructure. It would be great to be able to easily and rapidly come back to a previous commit of gateway instead of spending the time in building a new docker image locally.

Only downside is that docker hub doesn't really allow setting ourselves an automatic expiration of the docker images. Only quay.io does allow it. However, it seems like docker hub does it own automatic expiration so we should still be good with that: https://www.docker.com/blog/docker-hub-image-retention-policy-delayed-and-subscription-updates/

groldan commented 10 months ago

On the bright side, using spring-boot-maven-plugin to build the images means there will be a lot of shared layers across images. unless dependencies change, only the layer with the application classes should change between one and the other

edevosc2c commented 10 months ago

Maybe we should use github's container registry for these snapshot images.

That's what I thought but if we do it this way then it's for private usage because it would be "half" hidden from the public.

Whereas if it's in the same repo, the public can benefit from it.

Not sure on what's the best approach here.

groldan commented 10 months ago

as mentioned, feel free to merge since if you need it you need it. We can tackle the inconvenience later