search

georchestra / georchestra

This is the main geOrchestra Spatial Data Infrastructure repository, which hosts the source code.
http://www.georchestra.org/
GNU General Public License v3.0
129 stars 95 forks source link

console - take into account separate geonetwork database #3116

Open landryb opened 4 years ago

landryb commented 4 years ago

While upgrading to 20 i've seen https://github.com/georchestra/georchestra/blob/20.0.0/migrations/20.0/README.md#database-migration, looked a bit at the code in https://github.com/georchestra/georchestra/pull/2613 (mostly https://github.com/georchestra/georchestra/pull/2613#discussion_r285085780) to realize this hardcodes in the console (https://github.com/georchestra/georchestra/blob/f879c98a3b535a5ce071a6327aec2f8f369856f1/console/src/main/java/org/georchestra/console/ds/AccountGDPRDaoImpl.java#L67) the fact that geonetwork is a schema in the georchestra database.

For various historical reasons, we've always had geonetwork in a separate database, so the corresponding sql queries will blow hard at runtime :)

fvanderbiest commented 4 years ago

Good catch !

fvanderbiest commented 4 years ago

Would imply making use of https://github.com/georchestra/datadir/blob/7b6c7314c99e962eb11fd16948a5e1d47249aca4/geonetwork/geonetwork.properties#L20-L26 instead