search

georchestra / helm-georchestra

geOrchestra helm chart
3 stars 5 forks source link

console: add an env var for the private recaptcha key #76

Open jeanpommier opened 7 months ago

jeanpommier commented 7 months ago

Maybe it's just about setting an extra_environment entry. To check

edevosc2c commented 7 months ago

the question is if we want to include that as an option into the helm chart or not?

because if it's the latter one, it's already possible: set these helm values:

console:
  extra_environment:
    - name: RECAPTCHA_KEY
      value: "mykey"

then in console.properties:

privateKey=${RECAPTCHA_KEY}

Just my opinion, for me, I don't think this should be included in the helm chart. This is not a common parameter, and if we go that route then we may clutter the helm chart with the dozens of other "secret" parameters.

As a real example, for the gateway component we need to keep oauth credentials secret. I did set the credentials using the environment variable and I did set them as an environment inside security.yaml in the datadir for the gateway.

jeanpommier commented 7 months ago

Yes, that's why I added the comment. I had forgotten about this possibility. I just need to check it works but there's no reason why. Please let me check and I'll close the ticket

Thanks for the extensive answer anyway