georchestra / mapstore2-cadastrapp

repository for the mapstore2 version of cadastrapp
GNU General Public License v3.0
2 stars 10 forks source link

Request on landholding form : override the limitation is possible ! #101

Closed MaelREBOUX closed 3 years ago

MaelREBOUX commented 3 years ago

I can ask more than 5 demands there for I reached the limitation of 5 / week.

https://portail-test.sig.rennesmetropole.fr/cadastrapp/services/checkRequestLimitation?cni=maeltest&type=P3

The backend is clearly saying : "0 request left for this person"

{"requestAvailable":0,"user":{"commune":"","firstName":"mael","lastName":"reboux","adress":"","cni":"maeltest","codePostal":"","userId":1,"mail":"","type":"P3"}}

But the form let me ask some new demands. This can't be possible.

Could you reproduce @landryb @jusabatier ?

image

jusabatier commented 3 years ago

Reproduced here, but the print buttons still gayed and not clickable.

I agree that a red warning would be better.

offtherailz commented 3 years ago

It's ok to show the same message in the request object list, like when you are adding too many entries? image.png

offtherailz commented 3 years ago

I created this PR for this change, please let me know if it is ok for you, I'll merge. https://github.com/georchestra/mapstore2-cadastrapp/pull/110#issue-584007142