search

georchestra / mapstore2-cadastrapp

repository for the mapstore2 version of cadastrapp
GNU General Public License v3.0
2 stars 10 forks source link

selection tab title is misleading ? #115

Open landryb opened 3 years ago

landryb commented 3 years ago

when testing, @stous found it confusing that a graphical (point/line/polygon) selection tab title was 'Selection', since no entries are actually selected in the list. (shows 2 objets (0 sélectionnés))

adding to this, in the preferences tab, there are 'default' (translated as 'Liste') and 'selected' (translated as 'Sélection', cf https://github.com/georchestra/mapstore2-cadastrapp/blob/master/assets/translations/data.fr-FR.json#L84) - i'm not sure 'Selection X' is the best word to use .. should we reuse Liste there ? 'Résultat de recherche' is too large. Or it should be 'Point X'/'Line X'/'Polygon X' (with translations !) so that the user knows which tab matches a 'graphical selection' ?

this is discussed a bit in #93, and that also shows that 'Selection' isnt a translated string, which might be an issue too (in french it would be Sélection or something better) ? the various strings in https://github.com/georchestra/mapstore2-cadastrapp/blob/22733802af6bee4fe8521803f92611fee3c02cd3/js/extension/epics/search.js#L38-L58 arent translated either, and i havent found where 'Selection' comes from.

@MaelREBOUX @catmorales i'm sure you'll have ideas on this.....

MaelREBOUX commented 3 years ago

Hummm.... not easy.

Let's see :

image

I suggest we could manage only 2 kinds of events : Selection / Search ? Numbered as said in #93

landryb commented 3 years ago

but 'selection' is misleading here i think since there's a "second selection" to do in the list, so it should rather be 'point/line X' ?

MaelREBOUX commented 3 years ago

it should rather be 'point/line X'

No because your list selection could be done by the 3 geometric methods. I think dicriminate by selection / search method + numbered tabs is an acceptable way. Not ?