georchestra / mapstore2-cadastrapp

repository for the mapstore2 version of cadastrapp
GNU General Public License v3.0
2 stars 10 forks source link

positionning conflict between cadastrapp pane and omnibar/burger menu #133

Closed landryb closed 1 year ago

landryb commented 3 years ago

This is a followup to #73 which only fixed one conflict between cadastrapp pane and identify tool popup.

Users of cadastrapp are (once the cadastrapp pane is open) being confused by not being able to enter an address in the omnibar, or they complain they cant print the map or access the annotation tool pane or being able to add more layers via layer catalog... (eg all the tools available in the burger menu).

Sure, one can always close cadastrapp pane to reaccess all those features, but then one manually needs to readd the cadastre layer to be able to draw on it or print an area of interest.

Sure, i'll try to add the cadastre layer to the default map shipped in the context, but then i guess it might/will conflict with the same layer being loaded by cadastrapp when opening the pane.

So, all in all, i'd like to have a discussion on how to avoid all those positioning conflicts of tools hiding each other and making other tools unaccessible.. cant the burger menu and the omnibar position be relative to the cadastrapp pane, like this is the case for the other tools available in the bottom right toolbar ?

@jusabatier @MaelREBOUX @catmorales ?

landryb commented 3 years ago

i've tested adding the cadastre layer to the map context (from the same source returned by /cadastrapp/services/getConfiguration), and opening the cadastrapp pane doesn't readd it a second time (and closing the pane doesnt remove the layer either), so that can be a workaround, but users will still have to open/close the pane to access the omnibar and the burger menu to reach annotate/add layer/print. A bit awkward...

MaelREBOUX commented 3 years ago

@landryb do you except this ? With / without the burger menu (to discuss...) ?

capture_346-2

landryb commented 3 years ago

that would seem logical, with the regular burger menu that users will try accessing for other tools (measure, annotation,etc..) - yes i know they can close the cadastrapp pane, but they'll be confused anyway.

Gaetanbrl commented 3 years ago

that would seem logical, with the regular burger menu that users will try accessing for other tools (measure, annotation,etc..) - yes i know they can close the cadastrapp pane, but they'll be confused anyway.

Many tools can't be open in the same time to avoid conflict between MapStore2 core actions.

E.g if you open Cadastrapp and Annotation, what will happend with the main toolbar display or with others map clic actions ? For this example, Annotation needs to close Cadastrapp (not sur but seems logical and it's maybe the current behavior).

So, it could be a good idea to keep visible the "other tools" burger buttons only if all plugins inside could close visible / opened plugin.

About text bar, this tool have no conflict with cadastrapp (i think), so it should be useable all the time.

Gaetanbrl commented 3 years ago

In addition, some widgets (stats) could be hidden by a plugin UI.

catmorales commented 3 years ago

We will have the same problem with urbanism plugin because a lot of users needs to have both plugins (cadastrapp and urbanism) opened at the same time .

landryb commented 2 years ago

Fixed by #156 / duplicate of #150, at least for being able to access printing/omnibar when using cadastrapp. Yay!

MaelREBOUX commented 1 year ago

May we close this issue now ?

landryb commented 1 year ago

Yay !