search

georchestra / mapstore2-cadastrapp

repository for the mapstore2 version of cadastrapp
GNU General Public License v3.0
2 stars 10 forks source link

fix search by owner id/lot #171

Closed landryb closed 2 years ago

landryb commented 2 years ago

remove an hardcoded SEARCH_TYPE.USER that was added in #127. This PR fixes #154 for me.

I'm now sure #154 is a regression from #127 which fixed #123. If i use currentTab instead of the hardcoded SEARCH_TYPES.USER in https://github.com/georchestra/mapstore2-cadastrapp/blob/master/js/extension/components/search/OwnersSearch.jsx#L49 - then owner search by id works.

@offtherailz can you have a look at that regression and fix all cases ? Will do a PR with my local change but i'm not sure it covers all of them.

Sadly it seems all usecases weren't properly tested in #127.