search

georchestra / mapstore2-cadastrapp

repository for the mapstore2 version of cadastrapp
GNU General Public License v3.0
2 stars 10 forks source link

Positionning conflict between cadastrapp pane and urbanisme pane #181

Open rgoffinet opened 1 year ago

rgoffinet commented 1 year ago

Environment : portail-test.sig.rennesmetropole.fr Versions : mapstore2-georchestra 2022.02.00 & 2022.02.02

When using the plugin urbanisme (https://github.com/sigrennesmetropole/geor_urbanisme_mapstore), if i open cadastrapp and then close it, the urbanisme's buttons and the mapstore toolbar container stays where the left end of cadastrapp pane were.

cadastrappVSurbanisme

Gaetanbrl commented 1 year ago

I guess this is link to https://groups.google.com/u/1/g/mapstore-developers/c/McOPpqDhf-0

Gaetanbrl commented 1 year ago

@rgoffinet @MaelREBOUX Same behavior with toolbar if you remove urbanisme plugin from the context ?

rgoffinet commented 1 year ago

@Gaetanbrl A similar behavior happens with the plugin "signalement"

cadastrappVSsignalement

Gaetanbrl commented 1 year ago

oh ! I guess an update of map layout missing on close.

UPDATE_MAP_LAYOUT action is required to update toolbar / searchbar location on setup or close.

On setup :

https://github.com/georchestra/mapstore2-cadastrapp/blob/508307acabc219aea997b97a790649df37f40a43/js/extension/epics/setup.js#L66

On close (tearDown) :

https://github.com/georchestra/mapstore2-cadastrapp/blob/508307acabc219aea997b97a790649df37f40a43/js/extension/epics/setup.js#L210

landryb commented 3 months ago

is it still an issue or that's been fixed at some point ?

rgoffinet commented 3 months ago

It is still an issue. We haven't yet been able to test the modification proposed by Gaetanabrl.

On the other hand, the conflict with signalement has been solved with this commit https://github.com/sigrennesmetropole/geor_signalement/commit/421a676df4498e466ddaec34ec585629a6ed0986. This might help to solve this problem.