georchestra / mapstore2-georchestra

geOrchestra newest viewer
Other
6 stars 23 forks source link

Base layer selector - mime type format list shows too much possibilities #168

Open catmorales opened 4 years ago

catmorales commented 4 years ago

Map : https://georchestra.geo-solutions.it/mapstore/#/context/TestCatherine2 Base layers used : Ortho WMTS from Rennes Métropole's IDS Plugin activated : Base layer selector

If the plugin is activated, an user can modify the base layer properties including the mime format. For example this base layer is not served on png and it's possible to choice png format. The results is a blank map. image

Two questions:

landryb commented 4 years ago

getcapabilities returns a list of mimetypes, so yes only the available formats should be listed. was also reported in https://github.com/georchestra/mapstore2-georchestra/issues/108#issue-526621159

tdipisa commented 4 years ago

@mbarto can we consider to perform a GetCapabilities while opening the advaced options of a catalog source? We have choosen to have a fixed list of formats to avoid as much as possibIe GetCapabilites requests that sometime can require a lot of time for different kind of reasons; for this specific functionality the real benefits are doubtful I think. Moreover, with the current implementation, if you don't select a format in DD, MapStore automatically use the first mimetype available in the GetCapabilities response.

@landryb, for this topic I will open a separated issue in MapStore: this detail is not part of the original requirements so I will include that discussion in the usual MS release planning for the moment.

@catmorales, anyway we will provide a fix for the Background Selector edit buttons enablement: they should appear only to authenticated users with write permissions (there is an issue with this only in application contexts, in saved maps it works as expected MapStore side).

landryb commented 4 years ago

since you load the layer from a catalog, i'm pretty sure you already performed a GetCapabilities.. isnt the result of it available at that point ? could it be cached for a while ? iirc we discussed that at some point with @MaelREBOUX (caching GetCapabilities result for a while, with a button to force-reload it)