georchestra / mapstore2-georchestra

geOrchestra newest viewer
Other
6 stars 23 forks source link

Layer Editing - Editing tool #48

Closed tdipisa closed 4 years ago

tdipisa commented 5 years ago

This extension allows to edit features on the map through the WFST protocol. Different utilities of this extension allow to create, edit and delete features in the map when the corresponding layer in TOC is selected:

For this issue we can improve the existing Attribute Table tool in MapStore. What is currently missing there, is the capability to select a feature (and the corresponding record/s in table) directly clicking on map.

offtherailz commented 4 years ago

We should allow to filter data by click, so you can select data from map (in edit mode) and edit (one of the result, if more than one feature were in the same point clicked).

Evaluate during development if the user has a better experience by auto-selecting features during or not, because the feature of showing filtered data is provided also by the "map sync" functionality already shows only the data filtered (using WMS). As an alternative disable mapsync in this context.

MaelREBOUX commented 4 years ago

Could you point to a doc for the "map sync" functionality please ? If it exists. Thanks.

tdipisa commented 4 years ago

Hi @MaelREBOUX, the "map sync" utility is documented inside the Attribute Table documentation here

MaelREBOUX commented 4 years ago

Thank you : it is more clear. The sync table filter --> map is a powerfull tool.

Another question. Could you confirm me that if you want to edit an object on the map : you must know its primary key to select (or filter it) in the table ?

I mean : currently you cannot clic on the map to select the object you want to edit. You currently have to select it threw the table. Right ?

tdipisa commented 4 years ago

Thank you : it is more clear. The sync table filter --> map is a powerfull tool.

Good, thank you.

Another question. Could you confirm me that if you want to edit an object on the map : you must know its primary key to select (or filter it) in the table ?

Yes, you have to find (using the quick filter tool for example) the object to edit in table first and then select it and edit it.

I mean : currently you cannot clic on the map to select the object you want to edit. You currently have to select it threw the table. Right ?

Currently yes, but what we will provide for this issue is exactly to add the possibility to select an object in map too instead of necessarily select the record in table. Take a look at the description for this that reports the following:

For this issue we can improve the existing Attribute Table tool in MapStore. What is currently missing there, is the capability to select a feature (and the corresponding record/s in table) directly clicking on map.

MaelREBOUX commented 4 years ago

Currently yes, but what we will provide for this issue is exactly to add the possibility to select an object in map too instead of necessarily select the record in table. Take a look at the description for this that reports the following:

For this issue we can improve the existing Attribute Table tool in MapStore. What is currently missing there, is the capability to select a feature (and the corresponding record/s in table) directly clicking on map.

Perfect !

tdipisa commented 4 years ago

@vlt1 Moving it back to ready after testing.

If I edit a feature by selecting it in the Attribute Table with a click on the map an error occurs (gray page with reload button) but the feature is properly saved, this happens only if also the geometry is modified: the normal editing with selection in grid works.

How to reproduce