search

georchestra / mapstore2-georchestra

geOrchestra newest viewer
Other
6 stars 23 forks source link

#548 update master to 2022.02.xx #550

Closed alexander-fedorenko closed 2 years ago

alexander-fedorenko commented 2 years ago

Following changes are applied:

Related to https://github.com/georchestra/mapstore2-georchestra/milestone/15

tdipisa commented 2 years ago

Version plugin has not been removed check here the steps, should we migrate it to about and add back About to the viewer and other pages?

Since it is custom in this project. I've asked @alexander-fedorenko to skip that point. Let's leave it as it is now.

@alexander-fedorenko can you please check all the other points?

alexander-fedorenko commented 2 years ago

Thanks @MV88! @tdipisa checking

tdipisa commented 2 years ago

@MV88 @alexander-fedorenko

3d seems not working to me, or is not using directly the osm background

also in our georchestra DEV is the same. Maybe it is only a matter of fixing the configuration

alexander-fedorenko commented 2 years ago
tdipisa commented 2 years ago

@alexander-fedorenko this sounds strange

viewer embedded url: this is an issue of share plugin. Default viewer in geOrchestra is at root path ("/"); share plugin relies on "viewer/x/y" path when it parses URL string to display proper link in modal. Share module probably needs a minor change with an extra check to work in case of root path. @tdipisa

It is working in georchestra DEV now and I don't remember an update involving the Share plugin that generated this regression. Do you know that?

alexander-fedorenko commented 2 years ago

@alexander-fedorenko this sounds strange

viewer embedded url: this is an issue of share plugin. Default viewer in geOrchestra is at root path ("/"); share plugin relies on "viewer/x/y" path when it parses URL string to display proper link in modal. Share module probably needs a minor change with an extra check to work in case of root path. @tdipisa

It is working in georchestra DEV now and I don't remember an update involving the Share plugin that generated this regression. Do you know that? image

It behaves same way on dev, there is no "embedded.html" that should be there to make it work properly. The problem only exists for https://georchestra.geo-solutions.it/mapstore/ url

MV88 commented 2 years ago

backend commands: but they are also missing in project creation script? https://github.com/geosolutions-it/mapstore-project/blob/master/types/standard/scripts/create.js#L96 Correct me if I'm wrong @MV88

yes, we are now adding them with new pr reviews, here

so please include anyway since it can be useful to have these commands in the script list

tdipisa commented 2 years ago

@alexander-fedorenko (fyi @MV88)

It behaves same way on dev, there is no "embedded.html" that should be there to make it work properly. The problem only exists for https://georchestra.geo-solutions.it/mapstore/ url

Ah ok,. I understood what you mean now. It is the correct and expected behavior for this project where there can be only the default map viewer page (no MS landing page) and it need to be shared anyway. So no regressions/bugs here for this @MV88.

tdipisa commented 2 years ago

@MV88

also do we have to increase version of package.json?

yes but only for the new stable branch we will create here for the delivery. I've described to @alexander-fedorenko what should be the new procedure so that he is in the process to raise a new PR for this to change the README file including this.