search

georchestra / mapstore2-georchestra

geOrchestra newest viewer
Other
6 stars 23 forks source link

Add requirements section #678

Closed Gaetanbrl closed 6 months ago

Gaetanbrl commented 7 months ago

This pull request only change the README to :

landryb commented 6 months ago

fwiw, if node 16 is a requirement then https://github.com/georchestra/mapstore2-georchestra/blob/master/.github/workflows/mapstore.yml#L26 should be adjusted ?

Gaetanbrl commented 6 months ago

should be adjusted ?

Done @landryb

Gaetanbrl commented 6 months ago

Thanks @landryb ! :)

landryb commented 6 months ago

funny thing i just noted in the gh actions: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

i would have thought merging this PR and 8f60c29 fixed that warning .. but apparently not, per https://github.com/georchestra/mapstore2-georchestra/actions/runs/7384101859

landryb commented 6 months ago

bah, one needs to 'update' the version of the action used.