georchestra / mapstore2-georchestra

geOrchestra newest viewer
Other
6 stars 23 forks source link

geOrchestra overlay details #713

Open Gaetanbrl opened 1 month ago

Gaetanbrl commented 1 month ago

Description

It would be usefull to identify the special georchestra's features that overlay basic mapstore2 project.

Some examples :

I invite the community to add their knowledge to this issue via comments.

The final objective is to create a doc / have a trace (and why not a guide to be able to upgrade Mapstore2 submodule freely).

Gaetanbrl commented 1 month ago

Some links :

Gaetanbrl commented 1 month ago

Some customization was located in /js directory (e.g plugins) :

https://github.com/georchestra/mapstore2-georchestra/tree/master/js

Gaetanbrl commented 1 month ago

Here, a custom configuration to insert / use easyTheming plugin (not exists in nativ mapstore2) :

https://github.com/georchestra/mapstore2-georchestra/commit/6ba8f3beca40b609eed3ed3849c68a302509a871

Gaetanbrl commented 1 month ago

@f-necas what about custom docker (or other build stuff) config / files / build ?

f-necas commented 1 month ago

@f-necas what about custom docker (or other build stuff) config / files / build ?

We override server.xml but there's a PR upstream for that, as far as I know, not a lot of customization around docker .

Gaetanbrl commented 1 month ago

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/plugins/Login.jsx

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/plugins/UserSession.jsx

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/plugins/Header.jsx

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/plugins/NotAllowed.jsx

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/plugins/Version.jsx

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/plugins/EasyTheming.jsx

(see this commit to understand)

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/plugins/UserSession.jsx#L12 https://github.com/georchestra/mapstore2-georchestra/blob/master/js/epics/usersession.js#L67

landryb commented 1 month ago

the auth via sec-* headers is configured here: https://github.com/georchestra/mapstore2-georchestra/blob/master/web/src/main/resources/geostore-spring-security.xml#L55

Gaetanbrl commented 1 month ago

mapstore-georchestra use some Custom pages :

https://github.com/georchestra/mapstore2-georchestra/tree/master/js/pages

2 pages exists in mapstore2-georchestra :

I need to understand correctly what this pages do.

Gaetanbrl commented 1 month ago

Ok pages are used by application router (e.g mapstore/#/admin):

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/app.jsx#L25 https://github.com/georchestra/mapstore2-georchestra/blob/8a3b8a13aa68c1bafee4d89aad48abe897dc4c38/js/app.jsx#L99-L101

landryb commented 1 month ago

it's probably specific to georchestra, because a default mapstore has the context manager on /#/context-manager ?

Gaetanbrl commented 1 month ago

@landryb /admin page was added from https://github.com/georchestra/mapstore2-georchestra/issues/37

catmorales commented 1 month ago

I don't see if you spoke about the use of SP headers

catmorales commented 1 month ago

Sorry I saw in https://github.com/georchestra/mapstore2-georchestra/issues/713#issuecomment-2262542262

Gaetanbrl commented 1 month ago

it's probably specific to georchestra, because a default mapstore has the context manager on /#/context-manager ?

This is correct @landryb.

After some tests to reproduce /admin page in mapstore2, and as I understand it, this is how it seems works.

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/pages/Admin.jsx

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/app.jsx#L99-L101

https://github.com/georchestra/mapstore2-georchestra/blob/master/js/app.jsx#L99-L101

This config will specify the /admin page content. The default geOrchestra's localConfig.json file specify to use Header, omnibar, Loginand context-manager inside.

Note that localConfig doesn't content ContextManager plugin (replace by Admin I guess). Note that ContextManager is maybe (not sur) override by custom ContextCreator page.

catmorales commented 1 month ago

Note that localConfig doesn't content ContextManager plugin (replace by Admin I guess).

But it's the aim of https://github.com/georchestra/mapstore2-georchestra/blob/master/configs/pluginsConfig.json

Gaetanbrl commented 1 month ago

About Project and mapstore2 submodule update / migration : https://training.mapstore.geosolutionsgroup.com/project/introduction/index.html#mapstore2-submodule-update

Gaetanbrl commented 1 month ago

In best practice part :

The list above shows the most common checks but based on the complexity of the project customization we could have additional files to compare

We maybe needs some additional infos about these additional files to compare.