RC1 feedbacks and suggestions

jusabatier commented 2 years ago

I just tested the new RC1, it look great !

Here are some feedbacks :

a feature is missing : hover on the line chart's points show a map marker to locate it :
in the context editor, some french translations for the plugin (title, description) are missing
in the chart popup, some actions buttons look like they are disabled (style) For example, here the "Zoom" is enabled, but other looks like if they are disabled :

tdipisa commented 2 years ago

Thank you so much @jusabatier for the feedback ;)

alexander-fedorenko commented 2 years ago

Hi @jusabatier, I've faced an issue with showing marker for the hovered point: for some reason point coordinates returned from WPS are far beyond projected boundaries (https://epsg.io/2154) even though the request line is inside those boundaries.

Here is the WPS request example exported from postman:

curl --location --request POST 'https://georchestra.geo-solutions.it/geoserver/wps?service=WPS&version=1.0.0&REQUEST=Execute' \
--header 'User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:104.0) Gecko/20100101 Firefox/104.0' \
--header 'Accept: application/json, text/plain, */*' \
--header 'Accept-Language: en-US,en;q=0.5' \
--header 'Accept-Encoding: gzip, deflate, br' \
--header 'Content-Type: application/xml' \
--header 'X-KL-Ajax-Request: Ajax_Request' \
--header 'Origin: https://georchestra.geo-solutions.it/' \
--header 'Connection: keep-alive' \
--header 'Sec-Fetch-Dest: empty' \
--header 'Sec-Fetch-Mode: cors' \
--header 'Sec-Fetch-Site: same-origin' \
--header 'Pragma: no-cache' \
--header 'Cache-Control: no-cache' \
--data-raw '<?xml version="1.0" encoding="UTF-8"?><wps:Execute version="1.0.0" service="WPS" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.opengis.net/wps/1.0.0" xmlns:wfs="http://www.opengis.net/wfs" xmlns:wps="http://www.opengis.net/wps/1.0.0" xmlns:ows="http://www.opengis.net/ows/1.1" xmlns:gml="http://www.opengis.net/gml" xmlns:ogc="http://www.opengis.net/ogc" xmlns:wcs="http://www.opengis.net/wcs/1.1.1" xmlns:dwn="http://geoserver.org/wps/download" xmlns:xlink="http://www.w3.org/1999/xlink" xsi:schemaLocation="http://www.opengis.net/wps/1.0.0 http://schemas.opengis.net/wps/1.0.0/wpsAll.xsd"><ows:Identifier>gs:ProfilEnLong</ows:Identifier><wps:DataInputs><wps:Input><ows:Identifier>geometrie</ows:Identifier><wps:Data><wps:ComplexData mimeType="application/wkt"><![CDATA[LINESTRING(560720.7363823648 6592175.185956234,832344.2330455637 6595384.350178238)]]></wps:ComplexData></wps:Data></wps:Input><wps:Input><ows:Identifier>crs</ows:Identifier><wps:Data><wps:LiteralData>EPSG:2154</wps:LiteralData></wps:Data></wps:Input><wps:Input><ows:Identifier>distance</ows:Identifier><wps:Data><wps:LiteralData>100</wps:LiteralData></wps:Data></wps:Input><wps:Input><ows:Identifier>referentiel</ows:Identifier><wps:Data><wps:LiteralData>sfdem</wps:LiteralData></wps:Data></wps:Input></wps:DataInputs><wps:ResponseForm><wps:RawDataOutput><ows:Identifier>result</ows:Identifier></wps:RawDataOutput></wps:ResponseForm></wps:Execute>'

Coordinates of the first point: [560720.7363823648 6592175.185956234] https://epsg.io/map#srs=2154-1671&x=560720.7363823648&y=6592175.185956234&z=6&layer=streets Coordinates of the first point of response: [4165437.6657703295 11814915.116561575] https://epsg.io/map#srs=2154-1671&x=4165930.267023&y=11815394.392890&z=7&layer=streets

Could you check if you have same behavior on your environment? Thanks!

jusabatier commented 2 years ago

What is your 'referentiel' native SRS ? (the one of the GeoTIFF file)

Maybe a transform is missing when points are returned after retrieve them from file data.

jusabatier commented 2 years ago

After some investigations, I found that returned coordinates still in 'referentiel' layer's native SRS (=>GeoTIFF SRS). I didn't notice it in my use cases because I request same 'crs' as my 'referentiel' one.

I correct it, now they are reprojected to the requested 'crs' coordinate system.

You can found the patched jar here : https://gitlab.agglo-lepuyenvelay.fr/jusabatier/profil-en-long-wps/-/packages

Can you confirm me if it solve you problem ?

tdipisa commented 2 years ago

Thank you @jusabatier. We will install the patch asap to do a check.

tdipisa commented 2 years ago

I'm sorry @jusabatier for our DEV instance I think the correct one is this. Can you confirm please?

jusabatier commented 2 years ago

If I remember, you have a GS 2.16.1, if correct then this effectively is the jar you need.

tdipisa commented 2 years ago

@alexander-fedorenko the WPS fixed by @jusabatier has been installed and it seems working now.

jusabatier commented 2 years ago

Nice, https://github.com/georchestra/mapstore2-longitudinal-profile/releases/tag/v1.0.0-RC2 add the markers.

What about the 2 other points :

in the context editor, some french translations for the plugin (title, description) are missing
in the chart popup, some actions buttons look like they are disabled (style)

tdipisa commented 2 years ago

Nice, https://github.com/georchestra/mapstore2-longitudinal-profile/releases/tag/v1.0.0-RC2 add the markers.

Thank you so much @jusabatier

What about the 2 other points :

We have put our feedback in PR description here

in the context editor, some french translations for the plugin (title, description) are missing

The translation of title and description in context wizard list is not yet supported for extensions

in the chart popup, some actions buttons look like they are disabled (style)

It is the style of PlotlyJS, we didn't find a way to quickly/properly customize it so far.

georchestra / mapstore2-longitudinal-profile

RC1 feedbacks and suggestions #7