Vrt-bot log in file - Githubissues

georchestra / vrt-bot

A simple cron-like service which consumes VRT files and load them in a PostGIS database.

0 stars 1 forks source link

Vrt-bot log in file #7

Closed f-necas closed 7 months ago

f-necas commented 7 months ago

This PR adds logs to stdout and to vrtlog file.

It allows end-user to have an access to last vrt bot logs.

edevosc2c commented 7 months ago

I see two issues here:

There is no "logrotate" so your file will quickly grow up to a point of getting to a hundred GBs if you do not do anything after half a year. In Kubernetes there is a log rotation for pods logs, so no issues for the console logs. But for the file "vrtbot.log", you should do some kind of automatic log cleanup.
Also, if you think on the user side, having everything in a single log file makes it difficult to distinguish the errors from one vrt to another. It's not a critical issue but could help for the user experience.

pmauduit commented 7 months ago

There is no "logrotate" so your file will quickly grow up to a point of getting to a hundred GBs if you do not do anything after half a year.

the file is removed / recreated at each run

edevosc2c commented 7 months ago

There is no "logrotate" so your file will quickly grow up to a point of getting to a hundred GBs if you do not do anything after half a year.

the file is removed / recreated at each run

Right I haven't seen the "rm" command above.

Anyway after discussion with @f-necas.

The second point remains present, I proposed to keep the 10th last logs files. Because the user may want to see the previous logs of the vrt-bot import process.