search

geordanr / xwing

Squad builder for the First Edition X-Wing Miniatures game by Fantasy Flight Games.
http://geordanr.github.io/xwing
MIT License
97 stars 154 forks source link

Print function not working #138

Closed cquirkhome closed 9 years ago

cquirkhome commented 9 years ago

The print function on on the squad builder is not working correctly. It will not print in color, does not add in the icons for Pilot Skill, attack, agility, hull or shield, and some upgrade icons are also not appearing (modifications and Dauntless, for example).

I love the site and want to use the site but not have a good quality print function is a no go for me.
Can this be fixed?

Chris

geordanr commented 9 years ago

I am not able to reproduce the error Chrome running on Windows 7 and Ubuntu 14.04. What browser and OS are you using? Are you seeing the pilot skill/attack/etc. icons and color in the print preview?

Also, check to make sure you have background colors and images turned on in your browser's print options.

I do not have icons for modifications and titles; I moved icons to a separate project and will see about getting that updated to include those.

armoredgear7 commented 9 years ago

"I do not have icons for modifications and titles; I moved icons to a separate project and will see about getting that updated to include those."

I actually traced and optimized these too. Need to find some time to work with git.

geordanr commented 9 years ago

Awesome. I've got an issue filed against the font package here: https://github.com/geordanr/xwing-miniatures-font/issues/1

cquirkhome commented 9 years ago

Hey thanks for the reply. However, Im not sure I understand what you said. Im just a X wing player that likes cool squad builders.

The Icons and everything that does not print are there an in color when you view a list in fancy mode. It is only when you print it, it does not include the "fancy" items and only prints in black and white.

I get the part about not having icons. Does it now print in color is that still broken?

Thanks again,

Chris

From: Josh Derksen [mailto:notifications@github.com] Sent: Thursday, December 4, 2014 12:45 PM To: geordanr/xwing Cc: cquirkhome Subject: Re: [xwing] Print function not working (#138)

"I do not have icons for modifications and titles; I moved icons to a separate project and will see about getting that updated to include those."

I actually traced and optimized these too. Need to find some time to work with git.

Reply to this email directly or view it on GitHub https://github.com/geordanr/xwing/issues/138#issuecomment-65671636 . https://github.com/notifications/beacon/AJmyZtY6j4r5tReNLeW8ff5_IsMQLv1dks5 nUJUagaJpZM4DEKb8.gif

geordanr commented 9 years ago

When you click "Print" you should see a print preview (not the fancy view dialog -- there should be another one after that). Do the icons and colors show up in there?

What web browser and OS are you running? I want to try to reproduce this issue.

cquirkhome commented 9 years ago

This is what I get when I click "Print/View as text". Fancy is selected.

On the left is what I want to print. On the right is what I get. I use windows 8 with Mozilla Firefox

From: Geordan Rosario [mailto:notifications@github.com] Sent: Saturday, December 6, 2014 1:52 PM To: geordanr/xwing Cc: cquirkhome Subject: Re: [xwing] Print function not working (#138)

When you click "Print" you should see a print preview (not the fancy view dialog -- there should be another one after that). Do the icons and colors show up in there?

What web browser and OS are you running? I want to try to reproduce this issue.

Reply to this email directly or view it on GitHub https://github.com/geordanr/xwing/issues/138#issuecomment-65909224 . https://github.com/notifications/beacon/AJmyZnLLQi7PqCDzV4DA5HQ43rnWb0PHks5 nU0fKgaJpZM4DEKb8.gif

geordanr commented 9 years ago

Looks like GitHub doesn't handle attachments in responses. Could you put the image in an image hosting site and link it here?

I'll try Firefox on Win8 to reproduce.

cquirkhome commented 9 years ago

Dude, never mind. This is too much trouble for its worth. It is not that important to me. There are other squad builders to use. Bottom line, your builder does not print correctly in fancy mode. Pints in grayscale only, no colored numbers and no attack , agility, hull and shield icons and whatever else is there is that is supposed to print in color will not print in color in Mozilla or in IE on a cannon or Kodak printer. I've tried everything. If / when it gets resolved I might try it again. If not, no problem ther are others. I was just letting you know your site has an issue.

From: Geordan Rosario [mailto:notifications@github.com] Sent: Wednesday, December 10, 2014 11:31 PM To: geordanr/xwing Cc: cquirkhome Subject: Re: [xwing] Print function not working (#138)

Looks like GitHub doesn't handle attachments in responses. Could you put the image in an image hosting site and link it here?

I'll try Firefox on Win8 to reproduce.

Reply to this email directly or view it on GitHub https://github.com/geordanr/xwing/issues/138#issuecomment-66567802 . https://github.com/notifications/beacon/AJmyZn89UBwjKyJQ1JjK65OfJAenY7GQks5 nWRWXgaJpZM4DEKb8.gif

elistevens commented 9 years ago

@cquirkhome have you made sure that "Print Background Images" and "Print Background Colors" are checked in the Firefox print dialog (you may need to go into some advanced settings; I'm on FF/OSX right now and can reproduce the described issue if those aren't checked).

Note that this is what @geordanr meant when he said "Also, check to make sure you have background colors and images turned on in your browser's print options." in his first response to your ticket.