search

geordanr / xwing

Squad builder for the First Edition X-Wing Miniatures game by Fantasy Flight Games.
http://geordanr.github.io/xwing
MIT License
97 stars 153 forks source link

Bug for french Version #437

Closed sirmaugan closed 7 years ago

sirmaugan commented 7 years ago

Hi, i am To organiser and i love your builder, sadly since a little time french version as issues (mainly (always) when the card aren't translated), can you correct it ? maybe i can help for the card text ?

geordanr commented 7 years ago

Since I don't have access to non-English translations, I rely on others to contribute fixes to translations. Any help would be appreciated!

French translations are stored in here: https://raw.githubusercontent.com/geordanr/xwing/master/coffeescripts/cards-fr.coffee

You can make updates to it and either make a pull request (if you're comfortable with programming and using git and GitHub), or you edit that file and attach the updated file to a comment you make here.

sirmaugan commented 7 years ago

Ok thx, i will make that soon as possible, but it remain a problem i see in the file, that you let the English version of the card, but when you are in french somes cards (like All pilots from Rebels tie) stay empty

geordanr commented 7 years ago

Yeah; those were probably lazy copies on my part or things I forgot to put in. :(

sirmaugan commented 7 years ago

That's made (what a F... work, all my respect for the job you have done!) i attach the file here because i'm not really comfortable with programming (but i will try to correct that for the next time), i think that would correct the issue whith title for Defender, Bomber and maybee for the Sabine' Tie (but not sure) cards-fr.coffee.txt if i made errors, plz tell me !

geordanr commented 7 years ago

Thank you!

sirmaugan commented 7 years ago

Hi, thanks for this fast update... but it's have sommes problems i didn't see, so i have update the file for some: cards-fr.coffee.txt

and for the other: extra munitions: the text isn't in the file and when it's chose in the builder the squadron value stuck Glaive squadron are missing (in the file too) Gamma squadron Veteran are missing too

so i think the missing code must be something like :

"Extra Munitions" name: "Munitions supplémentaires" text: ""Quand vous êtes équipé de cette carte, placez un marqueur "ordonnance" sur chaque carte d'amélioration %TORPEDO%, %MISSILE% ou %BOMB% équipé. Quand on vous demande de défausser une carte d'amélioration, vous pouvez défausser 1 marqueur ordonnance sur cette carte à la place."""

"Glaive Squadron Pilot": ship: "Défenseur TIE" name: "Pilote de l'escadron Glaive"

"Gamma Squadron Veteran": ship: "Bombardier TIE" name: "Vétéran de l'escadron Gamma"

But i didn't know if it's enough and if the place in the file matters...

sirmaugan commented 7 years ago

hi, i made a update with Wave XI and C-Roc cards-fr.coffee.txt can you make the update ? thx

sirmaugan commented 7 years ago

bug correction for light scyk: (omited "ship:" ligne) cards-fr.coffee.txt

sirmaugan commented 7 years ago

Another correction : Glitterstim not present cards-fr.coffee.txt

thx :)

geordanr commented 7 years ago

For future fixes, please open a new issue so it's easier for me to find. I close issues once fixes have been applied so I can keep track of what I have addressed and what I have not; it's easy for me to miss updates on issues that are already closed.

Also, when making edits please make sure you are using the latest version of the file; I had added entries from Guns for Hire that I had to re-merge into your changes.

geordanr commented 7 years ago

There also seems to be some inconsistency with the indentation you're using (either with spaces or with tabs) which is making it difficult to merge these changes in. Please only use spaces to indent, and match the indentation (4 spaces per level); otherwise, the file will not compile in CoffeeScript (which it isn't, currently).

sirmaugan commented 7 years ago

Ok, sorry for mistakes

Rémy Foret

De : Geordan Rosariomailto:notifications@github.com Envoyé le :lundi 31 juillet 2017 20:05 À : geordanr/xwingmailto:xwing@noreply.github.com Cc : sirmauganmailto:sirmaugan@hotmail.com; Authormailto:author@noreply.github.com Objet :Re: [geordanr/xwing] Bug for french Version (#437)

There also seems to be some inconsistency with the indentation you're using (either with spaces or with tabs) which is making it difficult to merge these changes in. Please only use spaces to indent, and match the indentation (4 spaces per level); otherwise, the file will not compile in CoffeeScript (which it isn't, currently).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/geordanr/xwing/issues/437#issuecomment-319148492, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaA_ew-rUknMGCZm5mMiY4CnKWknfi-eks5sThdFgaJpZM4M541U.