geordanr / xwing

Squad builder for the First Edition X-Wing Miniatures game by Fantasy Flight Games.
http://geordanr.github.io/xwing
MIT License
97 stars 154 forks source link

having issues with log in button #608

Open turdferguson420 opened 4 years ago

turdferguson420 commented 4 years ago

YASB (First Edition) Bug Report

This bug report filer is for First Edition X-Wing only!

Note: If you are experiencing problems with the permalink URL when you have Maul or Bomblet Generator in your list, this is a known issue. For more information please see https://www.reddit.com/r/XWingTMG/comments/7c4q6h/yet_another_squad_builder_problems_with_maul/

Expected Behavior

Log In button is not activating

Actual Behavior

no action when pressed - is there a problem?

Language

English

geordanr commented 4 years ago

What browser (and version) are you using? There are changes that break older browsers (which is likely to appear on other sites).

turdferguson420 commented 4 years ago

Hi.

It's Chrome - not sure where I can find the version?

On Sat, Feb 15, 2020 at 1:51 PM Geordan Rosario notifications@github.com wrote:

What browser (and version) are you using? There are changes that break older browsers (which is likely to appear on other sites).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/geordanr/xwing/issues/608?email_source=notifications&email_token=AOR4EZZC6GEKF5TKXLBMGQTRDA2TNA5CNFSM4KVN3QOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL3UJSY#issuecomment-586630347, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOR4EZ2ZVVM6P67XUSVW453RDA2TNANCNFSM4KVN3QOA .

geordanr commented 4 years ago

Browse tochrome://version; that should tell you what version you're running.

turdferguson420 commented 4 years ago

Thanks. This is what I came up with: Google Chrome 79.0.3945.130 (Official Build) (32-bit) (cohort: Stable) Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@ {#1047}

On Wed, Feb 19, 2020 at 12:00 AM Geordan Rosario notifications@github.com wrote:

Browse tochrome://version; that should tell you what version you're running.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/geordanr/xwing/issues/608?email_source=notifications&email_token=AOR4EZ7FVER6VGB32QONYRTRDS4H3A5CNFSM4KVN3QOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMGLUCY#issuecomment-588036619, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOR4EZ7YSSJFWNXKWCVK773RDS4H3ANCNFSM4KVN3QOA .

geordanr commented 4 years ago

Strange, that should be compatible. What OS?

turdferguson420 commented 4 years ago

OS Windows 10 OS Version 1803 (Build 17134.1246)

On Wed, Feb 19, 2020 at 10:36 PM Geordan Rosario notifications@github.com wrote:

Strange, that should be compatible. What OS?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/geordanr/xwing/issues/608?email_source=notifications&email_token=AOR4EZYDRCXXVEQD4O2OI2DRDX3DNA5CNFSM4KVN3QOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMKTOEY#issuecomment-588592915, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOR4EZ6BYGTKB67JGUHY4ILRDX3DNANCNFSM4KVN3QOA .

geordanr commented 4 years ago

Did the login button ever work for you (and only stopped working recently)? If it never worked, you may have third party cookies disabled, which you'll need to allow. Otherwise, I'm not sure what's going on; does it work for other browsers on other machines?

turdferguson420 commented 4 years ago

Correct, the login button worked for at least a couple of years and only stopped functioning recently. It's a work PC; I have not knowingly changed any settings. I just tried to access via Explorer and it behaved the same way.

On Thu, Feb 20, 2020 at 11:45 AM Geordan Rosario notifications@github.com wrote:

Did the login button ever work for you (and only stopped working recently)? If it never worked, you may have third party cookies disabled, which you'll need to allow. Otherwise, I'm not sure what's going on; does it work for other browsers on other machines?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/geordanr/xwing/issues/608?email_source=notifications&email_token=AOR4EZZCY7J3PPTYD6UU7TTRD2XR3A5CNFSM4KVN3QOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMPCBLY#issuecomment-589177007, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOR4EZ2QYMH345HD5LCPJ6DRD2XR3ANCNFSM4KVN3QOA .

geordanr commented 4 years ago

In Chrome, while you have the builder open, hit F12 to open Developer Tools and click on the "Console" tab, then try to log in. What error messages (if any) do you see there?

turdferguson420 commented 4 years ago

Oh, looks like there's a bunch. A copy & paste follows:

2 xwing.min.js?1532065775:5 Error adding card "Heavy Scyk" Interceptor (title) from C-ROC Cruiser Expansion Pack VM5:1 Access to XMLHttpRequest at ' https://yasb-backend.herokuapp.com/methods' from origin ' http://geordanr.github.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. yasb-backend.herokuapp.com/methods:1 Failed to load resource: net::ERR_FAILED VM5:1 Access to XMLHttpRequest at 'https://yasb-backend.herokuapp.com/ping' from origin 'http://geordanr.github.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. yasb-backend.herokuapp.com/ping:1 Failed to load resource: net::ERR_FAILED geordanr.github.io/:1 Access to XMLHttpRequest at ' https://yasb-backend.herokuapp.com/settings' from origin ' http://geordanr.github.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. yasb-backend.herokuapp.com/settings:1 Failed to load resource: net::ERR_FAILED /favicon.ico:1 Failed to load resource: the server responded with a status of 404 (Not Found)

On Thu, Feb 20, 2020 at 10:16 PM Geordan Rosario notifications@github.com wrote:

In Chrome, while you have the builder open, hit F12 to open Developer Tools and click on the "Console" tab, then try to log in. What error messages (if any) do you see there?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/geordanr/xwing/issues/608?email_source=notifications&email_token=AOR4EZYDXG54MPODX6JEFCLRD5BSRA5CNFSM4KVN3QOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMRLVQA#issuecomment-589478592, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOR4EZYME7SPV3CHQNFTK6TRD5BSRANCNFSM4KVN3QOA .

geordanr commented 4 years ago

Now I'm really confused; the response I'm getting from the backend does have the Access-Control-Allow-* headers:

image

Does this happen for you on any other devices? Or in Incognito Mode (maybe something old is being cached)?

turdferguson420 commented 4 years ago

To answer your questions: -I usually go with Incognito, but I tried bringing up the page in reg. Chrome with same result. -Tried the page in Chrome on my BlackBerry just now and same issue. Log button gets highlighted in white when I press on it, but nothing happens just like on the PC at work.

On Mon, Feb 24, 2020, 23:15 Geordan Rosario, notifications@github.com wrote:

Now I'm really confused; the response I'm getting from the backend does have the Access-Control-Allow-* headers:

[image: image] https://user-images.githubusercontent.com/334985/75214339-0f0a1b00-5742-11ea-95b0-f3e8ff429d2b.png

Does this happen for you on any other devices? Or in Incognito Mode (maybe something old is being cached)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/geordanr/xwing/issues/608?email_source=notifications&email_token=AOR4EZ2OH2QBDOWPEHNFF6TRESLPXA5CNFSM4KVN3QOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM2PWKQ#issuecomment-590674730, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOR4EZ5IKUF5LUEVZSUEQZDRESLPXANCNFSM4KVN3QOA .

elistevens commented 4 years ago

I also get an error:

Access to XMLHttpRequest at 'https://yasb-backend.herokuapp.com/methods' from origin 'http://geordanr.github.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
yasb-backend.herokuapp.com/methods:1 Failed to load resource: net::ERR_FAILED
geordanr.github.io/:1 Access to XMLHttpRequest at 'https://yasb-backend.herokuapp.com/ping' from origin 'http://geordanr.github.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
yasb-backend.herokuapp.com/ping:1 Failed to load resource: net::ERR_FAILED
geordanr.github.io/:1 Access to XMLHttpRequest at 'https://yasb-backend.herokuapp.com/settings' from origin 'http://geordanr.github.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
yasb-backend.herokuapp.com/settings:1 Failed to load resource: net::ERR_FAILED
geordanr commented 4 years ago

Okay, this is weird. The error happens for me in incognito mode, but not in my normal browser.

If I try to simulate this with curl by sending different origins, I (correctly) get the access-control-* headers. Simulating access from YASB 1.0:

$ curl -I -H 'Origin: https://geordanr.github.io' https://yasb-backend.herokuapp.com/methods
HTTP/1.1 200 OK
Date: Wed, 26 Feb 2020 06:04:37 GMT
Connection: keep-alive
Access-Control-Allow-Origin: https://geordanr.github.io
Access-Control-Allow-Methods: GET, POST, PUT, DELETE
Access-Control-Max-Age: 7200
Access-Control-Allow-Credentials: true
Content-Type: application/json
Content-Length: 50
Vary: Origin
X-Content-Type-Options: nosniff
Server: thin
Via: 1.1 vegur

Simulating from YASB 2.0:

$ curl -I -H 'Origin: https://raithos.github.io' https://yasb-backend.herokuapp.com/methods
HTTP/1.1 200 OK
Date: Wed, 26 Feb 2020 06:06:14 GMT
Connection: keep-alive
Access-Control-Allow-Origin: https://raithos.github.io
Access-Control-Allow-Methods: GET, POST, PUT, DELETE
Access-Control-Max-Age: 7200
Access-Control-Allow-Credentials: true
Content-Type: application/json
Content-Length: 50
Vary: Origin
X-Content-Type-Options: nosniff
Server: thin
Via: 1.1 vegur

Simulating from an unauthorized origin (note lack of headers):

$ curl -I -H 'Origin: https://somethingelse.github.io' https://yasb-backend.herokuapp.com/methods
HTTP/1.1 200 OK
Date: Wed, 26 Feb 2020 06:06:23 GMT
Connection: keep-alive
Content-Type: application/json
Content-Length: 50
Vary: Origin
X-Content-Type-Options: nosniff
Server: thin
Via: 1.1 vegur

The request headers I'm sending are identical between normal and incognito mode, except for the do not track dnt header in normal, which doesn't appear to have any effect when I test with curl (normal is on the left, incognito on the right):

image

It doesn't matter whether I have cookies set in the yasb-backend.herokuapp.com domain, same behavior.

I'm completely stumped. Anyone else have ideas?

geordanr commented 4 years ago

Misclicked close

turdferguson420 commented 4 years ago

So it's not solvable then? Is there anything I can do on my end?

On Wed, Feb 26, 2020 at 1:16 AM Geordan Rosario notifications@github.com wrote:

Misclicked close

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/geordanr/xwing/issues/608?email_source=notifications&email_token=AOR4EZ5OSJUZV3TC2GSVXK3REYCK5A5CNFSM4KVN3QOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM66PJY#issuecomment-591259559, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOR4EZ5OQQHBLSPNC5LK5VLREYCK5ANCNFSM4KVN3QOA .

turdferguson420 commented 4 years ago

So I'm still trying to get logged in periodically. Chrome is now showing a button in the browser bar to allow cookies. Got excited when i clicked it as the log in button highlighted, but it still doesn't take any action when clicking on it.

Thanks,

Jude

On Wed, Feb 26, 2020 at 1:16 AM Geordan Rosario notifications@github.com wrote:

Misclicked close

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/geordanr/xwing/issues/608?email_source=notifications&email_token=AOR4EZ5OSJUZV3TC2GSVXK3REYCK5A5CNFSM4KVN3QOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM66PJY#issuecomment-591259559, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOR4EZ5OQQHBLSPNC5LK5VLREYCK5ANCNFSM4KVN3QOA .