georgberky / dependency-update-maven-plugin

A Maven plugin that creates merge requests for dependency updates.
Apache License 2.0
26 stars 9 forks source link

[#45] fix NPE when resolving Artifact from ArtifactFactory. #46

Closed bmarwell closed 2 years ago

bmarwell commented 2 years ago

Fixes #45 (NPE)

codecov-commenter commented 2 years ago

Codecov Report

Merging #46 (b90bcb5) into master (ddfa2fa) will increase coverage by 0.54%. The diff coverage is 0.00%.

:exclamation: Current head b90bcb5 differs from pull request most recent head 5a2b6e8. Consider uploading reports for the commit 5a2b6e8 to get more accurate results

@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
+ Coverage     67.21%   67.75%   +0.54%     
- Complexity       37       40       +3     
============================================
  Files            10       10              
  Lines           183      183              
  Branches          8       10       +2     
============================================
+ Hits            123      124       +1     
+ Misses           54       51       -3     
- Partials          6        8       +2     
Impacted Files Coverage Δ
.../maven/plugins/depsupdate/ArtifactoryExtensions.kt 100.00% <ø> (ø)
...erky/maven/plugins/depsupdate/NativeGitProvider.kt 100.00% <ø> (ø)
...rgberky/maven/plugins/depsupdate/UpdateResolver.kt 85.00% <0.00%> (-2.50%) :arrow_down:
...orgberky/maven/plugins/depsupdate/VersionUpdate.kt 87.50% <0.00%> (+25.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ddfa2fa...5a2b6e8. Read the comment docs.

georgberky commented 2 years ago

Hi @bmarwell , thanks for contributing! 🥳 I will read the code and get back to you.

bmarwell commented 2 years ago

@georgberky @sparsick any updates?

sparsick commented 2 years ago

Hi @bmarwell, currently, we both are busy with our daily work. Your PR is on our to-do list. We hope that we find in the next days time to have a look on it.

georgberky commented 2 years ago

@bmarwell , we have merged your PR. Thank you for your patience and your contribution 🙏🏻