search

georgberky / dependency-update-maven-plugin

A Maven plugin that creates merge requests for dependency updates.
Apache License 2.0
26 stars 9 forks source link

Method VersionUpdate::canSkip should be named "VersionUpdate::canApply" #49

Closed bmarwell closed 1 year ago

bmarwell commented 2 years ago

Method is used contrary to naming:

 UpdateResolver(
                    mavenProject = mavenProject,
                    artifactMetadataSource = artifactMetadataSource,
                    localRepository = localRepository,
                    artifactFactory = artifactFactory
            )
            .updates
            .onEach { println("execute im mojo: latestVersion: '${it.latestVersion}' / version:'${it.version}'") }
            .filter(VersionUpdate::canSkip)
sparsick commented 2 years ago

Thank you. Yes, we also recognize it. We will change it with https://github.com/georgberky/dependency-update-maven-plugin/pull/44