georgberky / dependency-update-maven-plugin

A Maven plugin that creates merge requests for dependency updates.
Apache License 2.0
27 stars 9 forks source link

[#48] exclude reactor projects #52

Closed bmarwell closed 2 years ago

bmarwell commented 2 years ago

fixes #48

This PR will exclude reactor projects. See description from the issue.

Contents:

sparsick commented 2 years ago

Build failed because of something with mockk. I have to check it locally if it's reproducable.

bmarwell commented 2 years ago

Build failed because of something with mockk. I have to check it locally if it's reproducable.

I used the SDK from .sdkmanrc which worked fine on MacOS. But I saw serious problems with ANY other JDK and JDK version: Neither OpenJ9 nor any Java 11/17/18/19 JDK would work. 😢

sparsick commented 2 years ago

On local Linux it also works. I check the docker image. It uses openjdk 8u233. I will check if we can use another docker image.

sparsick commented 2 years ago

With mockk 1.9.3 it works. I will sync the docker image jdk version sdkmanrc and in a separate PR

sparsick commented 2 years ago

https://github.com/georgberky/dependency-update-maven-plugin/pull/53/

syncs the version between SDKMAN and DroneCI

sparsick commented 2 years ago

@bmarwell I think we should do the version update in a separate PR to go further with this PR

bmarwell commented 2 years ago

@bmarwell I think we should do the version update in a separate PR to go further with this PR

Yes. I will rebase it once https://github.com/georgberky/dependency-update-maven-plugin/pull/57 is merged.

bmarwell commented 2 years ago

@sparsick rebased onto https://github.com/georgberky/dependency-update-maven-plugin/pull/57 (because #57 is needed anyway). So it looks like two commits, but it is only one after merging #57.

codecov-commenter commented 2 years ago

Codecov Report

Base: 68.27% // Head: 67.17% // Decreases project coverage by -1.10% :warning:

Coverage data is based on head (85be902) compared to base (15e0d76). Patch coverage: 58.82% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #52 +/- ## ============================================ - Coverage 68.27% 67.17% -1.11% - Complexity 40 46 +6 ============================================ Files 10 10 Lines 186 198 +12 Branches 10 16 +6 ============================================ + Hits 127 133 +6 - Misses 51 53 +2 - Partials 8 12 +4 ``` | [Impacted Files](https://codecov.io/gh/georgberky/dependency-update-maven-plugin/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Georg+Berky) | Coverage Δ | | |---|---|---| | [.../georgberky/maven/plugins/depsupdate/UpdateMojo.kt](https://codecov.io/gh/georgberky/dependency-update-maven-plugin/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Georg+Berky#diff-c3JjL21haW4va290bGluL2lvL2dpdGh1Yi9nZW9yZ2Jlcmt5L21hdmVuL3BsdWdpbnMvZGVwc3VwZGF0ZS9VcGRhdGVNb2pvLmt0) | `0.00% <0.00%> (ø)` | | | [...rgberky/maven/plugins/depsupdate/UpdateResolver.kt](https://codecov.io/gh/georgberky/dependency-update-maven-plugin/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Georg+Berky#diff-c3JjL21haW4va290bGluL2lvL2dpdGh1Yi9nZW9yZ2Jlcmt5L21hdmVuL3BsdWdpbnMvZGVwc3VwZGF0ZS9VcGRhdGVSZXNvbHZlci5rdA==) | `80.00% <71.42%> (-5.00%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Georg+Berky). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Georg+Berky)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sparsick commented 2 years ago

Thanks for your PR @bmarwell