Closed bmarwell closed 2 years ago
Build failed because of something with mockk. I have to check it locally if it's reproducable.
Build failed because of something with mockk. I have to check it locally if it's reproducable.
I used the SDK from .sdkmanrc which worked fine on MacOS. But I saw serious problems with ANY other JDK and JDK version: Neither OpenJ9 nor any Java 11/17/18/19 JDK would work. 😢
On local Linux it also works. I check the docker image. It uses openjdk 8u233. I will check if we can use another docker image.
With mockk 1.9.3 it works. I will sync the docker image jdk version sdkmanrc and in a separate PR
https://github.com/georgberky/dependency-update-maven-plugin/pull/53/
syncs the version between SDKMAN and DroneCI
@bmarwell I think we should do the version update in a separate PR to go further with this PR
@bmarwell I think we should do the version update in a separate PR to go further with this PR
Yes. I will rebase it once https://github.com/georgberky/dependency-update-maven-plugin/pull/57 is merged.
@sparsick rebased onto https://github.com/georgberky/dependency-update-maven-plugin/pull/57 (because #57 is needed anyway). So it looks like two commits, but it is only one after merging #57.
Base: 68.27% // Head: 67.17% // Decreases project coverage by -1.10%
:warning:
Coverage data is based on head (
85be902
) compared to base (15e0d76
). Patch coverage: 58.82% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks for your PR @bmarwell
fixes #48
This PR will exclude reactor projects. See description from the issue.
Contents: