search

georgberky / dependency-update-maven-plugin

A Maven plugin that creates merge requests for dependency updates.
Apache License 2.0
27 stars 9 forks source link

Version updates in module poms are not covered by git add #54

Open ascheman opened 2 years ago

ascheman commented 2 years ago

I have a multi module project where some of the modules define versions themselves. The versions are updated but the POM files seem not to become part of the final git commit.

I will try to create a test scenario/test case for this as soon as my time permits.

sparsick commented 2 years ago

Thanks for reporting.

sparsick commented 2 years ago

During Cyberland Hacktoberfest event, we could reproduce it with JGit provider (only manually).

Changed files are not part of a commit

sparsick commented 2 years ago

Root cause: JGit Provider only add root pom.xml because of line https://github.com/georgberky/dependency-update-maven-plugin/blob/122ce217d3f552516378f1f2c2f32272b401d8c5/src/main/kotlin/io/github/georgberky/maven/plugins/depsupdate/UpdateMojo.kt#L58

Native git provider uses it as pattern, but JGit Provider as file name.