Flag language toggle

[chrvt]

Added the option to show country flags (or any .svg file) instead of the language id for the language toggle, see https://github.com/george-gca/multi-language-al-folio/issues/11#issue-2074092015

[george-gca]

Thanks for your contribution, this is indeed a nice addition.

Only two things:

• you forgot to add .idea/ directory to .gitignore, so it ended up in the commit
• add the site.flags to _config.yml and set it as default to false. This way it is easy to spot how to change that. Also, what do you think of renaming it to country_flags? This way it doesn't get mixed with flags as a programming thing.

Fixing these 2 things and the commit passing in the recently added prettier formatter, I will be happy to merge this PR.

[chrvt]

Thanks for your quick answer. I am happy that you agree with the addition.

Sorry for the inconveniences caused by my sloppiness. I will add .idea/ to .gitignore and, of course, add the site.flags to _config.yml with default value of false. I like your suggestion to call it country_flags. I will make the corresponding changes and update my pull request.

[chrvt]

I updated the commit, however, not sure what you mean by "commit passing in the recently added prettier formatted" - is there something I should do?

[george-gca]

Yes, you should update your branch with the latest changes added to the repo. I recently applied here a lot of changes made to the base repository.

[george-gca]

Just making it clear, I recently added a lot of updates from al-folio here, and one of them check if the code is in the correct format defined by prettier.

[chrvt]

ok got it, should be fine now (fingers crossed)

[george-gca]

You forgot to delete the .idea/ directory from the commit. Also it is not passing in the prettier check as you can see above. Unfortunately the prettier check only outputs the file names, not how to fix them. I am trying to find a way to output this information yet. Meanwhile one of the ways to fix that is by using some kind of integration like with VSCode or installing it and running it manually.

[chrvt]

all right, will try to make my code prettier then ;-)

[george-gca]

@chrvt its been a while since your last commit, so I decided to take a look at the flags. While looking at their repo I saw that they support _sass, which would be better in our case. This way the only thing missing would be for the user to add the svg images from their repo at the right place. Since in our workflow we purge unused css, it will automatically discard all unused flags css, keeping only the ones needed.

[george-gca]

Now this is supported in latest version of the code.

[chrvt]

Great, thanks a lot!