george-hopkins / opentom

[Unofficial] Tiny Linux distribution for TomTom™ devices
Other
74 stars 33 forks source link

Enable power button, add s, use SiRFstarIII direct #20

Closed gefin closed 7 years ago

gefin commented 8 years ago

first sorry for the wrong pull requests.

you can use the power button to suspend the device while any program or navit is running in fullscreen. Also low batt suspend work.

There is one mistake in start.sh: wrong is power_button -b bin/suspend /bin/suspend right is power_button -b bin/suspend bin/suspend

SiRFstarIII GPS work without gltt.

i added the s script because profile don' t work at telnet login.

george-hopkins commented 8 years ago

Thank you for your contributions! The new daemon for the power button and support for devices without gltt will definitely improve the user experience :+1:

I cherry-picked your commits and pushed them to the navit branch (even tough some are not related to Navit).

As for the telnet sessions: I couldn't reproduce the case just yet. Do you use telnet over USB or Bluetooth?

gefin commented 7 years ago

I use both. Sorry. I don't know why it not worked. Now it work perfect via BT and USB.

Thanks.

gefin commented 7 years ago

This line in rc.gltt break the pipe between navit and gltt at resume from suspend . We should not remove the pipe. gpstype don't change on a device. After reboot the pipe or symlink is gone in any case.

Remove existing communication pipe

rm -f /var/run/gpspipe                 

I think so it is better to come around the error message :

:# Create new communication pipe for the application [ -e /var/run/gpspipe ] || mknod /var/run/gpspipe p

p.s. just noticed that not all TT send "low batt" TTXL does not, TT730 send it. I think about reading the battery voltage...

george-hopkins commented 7 years ago

Thank you for reviewing the changes. I integrated your fix for the broken pipe in 2fd5534.

For the low battery detection: Please don't feel urged to fix it for all the devices. I think it's already a nice improvement to have it working on some devices and worth including anyway.