george8188625 / Create-Diesel-Generators

Source code of Create Diesel Generators mod
https://www.curseforge.com/minecraft/mc-mods/create-diesel-generators
MIT License
22 stars 36 forks source link

[Question/Compatibility] Why are chemical sprayer projectiles never on fire #95

Open darklordwonton opened 7 months ago

darklordwonton commented 7 months ago

I was trying to figure out why the chemical sprayer wasn't working with dynamic lighting since I assumed that the projectiles that are fired when you light gasoline were on fire, which makes vanilla flaming arrows and on-fire projectiles from other mods glow. I looked into the code and noticed that while it looks like those projectiles are given the Fire tag there's an overload for isOnFire that makes it always return false (https://github.com/george8188625/Create-Diesel-Generators/blob/1.19.2/src/main/java/com/jesz/createdieselgenerators/entity/ChemicalSprayerProjectileEntity.java#L188). I assume there's probably a good reason for that, I'm just curious as to what that reason is.

I guess this is also a bug report/feature request that flaming chemical sprayer projectiles don't work with dynamic lighting mods. Not a major issue but it would look pretty cool if it was compatible.