georgeamccarthy / protein_search

The neural search engine for proteins.
GNU Affero General Public License v3.0
15 stars 6 forks source link

Include YAML config file #18

Open fissoreg opened 3 years ago

fissoreg commented 3 years ago

We need a configuration file where to specify the Huggingface/JinaHub model and other parameters (e.g. the directory where to store the embeddings, currently hardcoded).

There's already a backend_config.py file for the purpose. It works and the intent is clear, but it's maybe not the most orthodox way to deal with configurations. As Jina does, we could add a YAML file for configurations. @georgeamccarthy ?

georgeamccarthy commented 3 years ago

Good idea, relevant links:

georgeamccarthy commented 3 years ago

This would work well if we use Executors from the Hub.

Rubix982 commented 3 years ago

Where would we like to integrate the YAML file configurations? Sadly not possible with Dockerfiles at this moment, but what configurations from the backend can we put into a YAML file?

fissoreg commented 3 years ago

Basically the backend_config.py can be turned into a backend_config.yml and moved out of src into backend.

georgeamccarthy commented 3 years ago

@Rubix982 here's some depreciated (Jina 1.0) docs on YAML https://docs1.jina.ai/chapters/yaml/. I believe somewhat similar concepts still apply.