Simple logging - Githubissues

georgeamccarthy / protein_search

The neural search engine for proteins.

GNU Affero General Public License v3.0

15 stars 6 forks source link

Simple logging #26

Closed georgeamccarthy closed 3 years ago

georgeamccarthy commented 3 years ago

Pull Request Type

Select the type of changes and add some context. After selecting, remove the rest of the types.

🏆 Enhancements - adds simple command line logging if enabled.

Purpose

Useful to see progress logs, especially during development.

Why?

Indexing takes a long time on my machine, logging revealed this is at the stage of computing the embeddings.
Also see #23

Feedback required over

A quick pair of :eyes: on the code

Mentions

@fissoreg

References

https://github.com/georgeamccarthy/protein_search/pull/25

fissoreg commented 3 years ago

Looks nice, useful and simple!

At a certain point I think we should rather align to the Python logging standard: https://docs.python.org/3/howto/logging.html

And specifically with a Jina flavor: https://docs.jina.ai/api/jina.logging.logger/

We can merge this now and keep #23 open for the enhancements.