Feature: Reimplement Indexer using built in Jina docs.matches - Githubissues

georgeamccarthy / protein_search

The neural search engine for proteins.

GNU Affero General Public License v3.0

15 stars 6 forks source link

Feature: Reimplement Indexer using built in Jina docs.matches #48

Closed georgeamccarthy closed 3 years ago

georgeamccarthy commented 3 years ago

PR type

🏆 Enhancements
🏠 Internal

Purpose

Refactors and reimplements indexing with Jina built in: docs.match.
Handled slightly different response format in frontend.
Removed protein index limit.
Removed unnessesary saving & loading of embeddings and results where not needed.

Why?

closes #43
closes #38 (removed unnecessary results.json)

Feedback required over

A quick pair of :eyes: on the code

Mentions

@fissoreg

Testing

Works on my build! :)

fissoreg commented 3 years ago

I love this PR! Got rid of quite a bit of messy code with a simple standard method.

I left a couple of minor comments, but I would like to see this merged as soon as possible.

georgeamccarthy commented 3 years ago

Great to have the messy index code simplified! Will be much easier to test different indexing methods now.