search

georgeboot / laravel-echo-api-gateway

Use Laravel Echo with API Gateway Websockets. Works with Bref.sh and Laravel Vapor.
MIT License
99 stars 21 forks source link

Presence channel handler #25

Open jdavidbakr opened 2 years ago

jdavidbakr commented 2 years ago

Finishes https://github.com/georgeboot/laravel-echo-api-gateway/issues/23

codecov[bot] commented 2 years ago

Codecov Report

Merging #25 (db495f1) into master (2031401) will decrease coverage by 1.88%. The diff coverage is 32.55%.

@@             Coverage Diff              @@
##             master      #25      +/-   ##
============================================
- Coverage     45.30%   43.42%   -1.89%     
- Complexity       61       71      +10     
============================================
  Files             9        9              
  Lines           373      456      +83     
  Branches         14       14              
============================================
+ Hits            169      198      +29     
- Misses          196      250      +54     
  Partials          8        8
Flag Coverage Δ
jest 51.14% <0.00%> (-2.46%) :arrow_down:
pest-8.0 40.30% <35.00%> (-0.83%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js-src/Channel.ts 33.33% <0.00%> (-6.67%) :arrow_down:
src/SubscriptionRepository.php 8.45% <0.00%> (-5.84%) :arrow_down:
src/Handler.php 64.33% <53.06%> (-2.34%) :arrow_down:
src/ConnectionRepository.php 87.50% <100.00%> (+0.83%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2031401...db495f1. Read the comment docs.

jdavidbakr commented 2 years ago

Not sure how to test the presence channels, it fails when I try because of the authorization check