search

georgeboot / laravel-echo-api-gateway

Use Laravel Echo with API Gateway Websockets. Works with Bref.sh and Laravel Vapor.
MIT License
99 stars 23 forks source link

Remove AXIOS dependency #30

Closed Adesin-fr closed 2 weeks ago

Adesin-fr commented 2 weeks ago

We should replace Axios by browser's fetch API, which is now a few years old and should be supported on most users' browsers.

It's a few lines change, I'll handle it ASAP.

Adesin-fr commented 2 weeks ago

WelL... In facts, building doesn't work anymore if axios is not present, since laravel's echo js package needs it...

leob commented 2 weeks ago

@Adesin-fr Okay so we're not going ahead with this one ... yeah it's fine, it works with Axios (our own app already uses Axios anyway so for us it doesn't add to the bundle size)

Adesin-fr commented 2 weeks ago

That what not exactly the case : my app did not use axios, I removed it from my package.json... But NodeJS because of others packages (such as Echo), it's still used ;)

leob commented 2 weeks ago

That what not exactly the case : my app did not use axios, I removed it from my package.json... But NodeJS because of others packages (such as Echo), it's still used ;)

@Adesin-fr Yes I understand, but our app does use Axios ;-)

(and Echo yes that's pretty essential within the architecture, Laravel depends on ir)