search

georgeboot / laravel-echo-api-gateway

Use Laravel Echo with API Gateway Websockets. Works with Bref.sh and Laravel Vapor.
MIT License
99 stars 21 forks source link

Default to empty array. #7

Closed mikebronner closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #7 (07bbeb4) into master (1e64211) will decrease coverage by 0.46%. The diff coverage is 14.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #7      +/-   ##
============================================
- Coverage     37.93%   37.46%   -0.47%     
- Complexity       51       53       +2     
============================================
  Files             9        9              
  Lines           319      323       +4     
  Branches         14       14              
============================================
  Hits            121      121              
- Misses          190      194       +4     
  Partials          8        8
Flag Coverage Δ Complexity Δ
jest 54.47% <ø> (ø) 0.00 <ø> (ø)
pest 27.00% <14.28%> (-0.56%) 0.00 <4.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/ConnectionRepository.php 0.00% <0.00%> (ø) 3.00 <2.00> (+1.00)
src/SubscriptionRepository.php 0.00% <0.00%> (ø) 7.00 <2.00> (+1.00)
src/ServiceProvider.php 100.00% <100.00%> (ø) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1e64211...07bbeb4. Read the comment docs.

mikebronner commented 3 years ago

Sorry, just fixed those typos.

georgeboot commented 3 years ago

Thanks for taking the time to create this PR. However, this PR fixes the symptoms, not the actual cause of the issue.

I will try and see if I can find the underlying cause. Feel free to submit a new PR if you think you've found it!