search

georgebrindeiro / scroll-sync

Atom editor package: Synchronize scrolling of two editor panes by content.
MIT License
29 stars 8 forks source link

TextEditor.onDidChangeScrollTop -version 0.2.3 #27

Closed trunghieu7393 closed 6 years ago

trunghieu7393 commented 7 years ago

TextEditor.onDidChangeScrollTop - :2945:18

- /Users/trunghieu7393/.atom/packages/scroll-sync/lib/scroll-sync.coffee:120:57 ScrlSync.startTracking - /Users/trunghieu7393/.atom/packages/scroll-sync/lib/scroll-sync.coffee:124:17 atom-workspace.subToggle.add.atom.commands.add.scroll-sync:toggle - /Users/trunghieu7393/.atom/packages/scroll-sync/lib/scroll-sync.coffee:31:28 CommandRegistry.handleCommandEvent - :18901:35 handleCommandEvent - :18639:65 i'm using atom version 1.18.0
georgebrindeiro commented 7 years ago

Hi @trunghieu7393! I just released this version yesterday and I'm using Atom 1.18.0. I'll look into the error, but could you give me some more info about the issue so I can replicate the error?

  1. How did you activate ScrlSync?
  2. What other packages do you have active?
  3. What is your OS version?
  4. Anything else you might find relevant
georgebrindeiro commented 7 years ago

I just took a look at the source code around the lines that led to the error. The issue seems to be related to the textChanged generator function, which creates a map of the corresponding lines for each pane. Could you also share the files that were open in each pane for testing?

trunghieu7393 commented 7 years ago

@georgebrindeiro How did you activate ScrlSync?

What other packages do you have active?

What is your OS version?

Could you also share the files that were open in each pane for testing?

do you need other info?

georgebrindeiro commented 7 years ago

Unfortunately yes, as I am not able to reproduce your error. Could you fill in this template?

Description

[Description of the issue]

Steps to Reproduce

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior: [What you expect to happen]

Actual behavior: [What actually happens]

Reproduces how often: [What percentage of the time does it reproduce?]

Versions

atom 1.18.0 scroll-sync 2.3.0 macOS sierra 10.12.5

Additional Information

[Any additional information, configuration or data that might be necessary to reproduce the issue.]

georgebrindeiro commented 7 years ago

@trunghieu7393 are you still facing this issue?

trunghieu7393 commented 7 years ago

@georgebrindeiro i'm using atom version 1.21.1 and i can scroll sync two files.

georgebrindeiro commented 6 years ago

Since the issue isn't relevant any more, I'm closing it. Thanks!