search

georgebrindeiro / scroll-sync

Atom editor package: Synchronize scrolling of two editor panes by content.
MIT License
29 stars 8 forks source link

change status bar element to icon #30

Closed UziTech closed 6 years ago

UziTech commented 6 years ago

This pull request has a few different things in it.

  1. status-bar dependency is not used and not needed to consume the atom status bar service
  2. Changed the status bar element to an icon with a tooltip that will only show when two panes are open and will automatically hide if one is removed or more than two are open
  3. Allows the status bar to toggle scroll-sync on and off
  4. Removed the activationCommands parameter from package.json to allow the status bar icon to show before the user turns scroll-sync on
UziTech commented 6 years ago

this fixes #26

georgebrindeiro commented 6 years ago

@UziTech Nice! Thanks a lot for your detailed commits and comments. I will test these as soon as I get home today and, if everything checks out, I will roll out the changes soon after. Cheers!