search

georgemandis / konami-js

Adding the Konami Code easter egg to your projects since 2009! Compatible with gestures on smartphones and tablets as well. Compatible with all front-end frameworks and vanilla JavaScript
http://konamijs.mand.is/
MIT License
959 stars 121 forks source link

Make this RequireJS compatible. #3

Closed remybach closed 11 years ago

remybach commented 11 years ago

Thanks to @jackfranklin for the help on this.

jackfranklin commented 11 years ago

I would change the conditional to:

typeof define === "function"

Rather than just checking for define.

remybach commented 11 years ago

Fair point... updating now.

georgemandis commented 11 years ago

Nice work, however in light of some other pull requests and attention I've decided to streamline the repo and not bake-in and specific module support. I'd strongly encourage you to fork the repo and implement this there.

Thanks, George