Closed BenBergman closed 7 years ago
Good catch! Do you a have a pull request to fix it? I could review and make one but probably won't have time for a while.
I didn't have a chance to make a PR yet, but hopefully I'll have some time later this week.
I submitted a PR for this fix. Let me know if there is anything I should be doing to improve the PR.
Thanks! It seems fine, but I want to review it properly before merging in case I thought thoughts or suggestions. I just haven't had time, but should this weekend.
With the current code setup the user is able to have any gestures or taps present between the expected pattern elements and it will still execute correctly. For example, the following sequence will trigger the easter egg:
This could become a problem for pages that demand a lot of user interaction. Extended use of a page is likely to cause accidental triggering of the easter egg.